Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include the closing tag for a formatted mrkdwn channel #19

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: include the closing tag for a formatted mrkdwn channel #19

merged 1 commit into from
Dec 2, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Dec 2, 2024

Type of change

  • Bug fix

Summary

This PR updates the formatted channel ID before sending the text to the LLM 🤖 🙏 ✨

AFAIK this hasn't been causing issues with the responses, but I'm hoping this somehow adds stability to these requests!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the bug Something isn't working label Dec 2, 2024
@zimeg zimeg requested a review from misscoded December 2, 2024 21:10
@zimeg zimeg self-assigned this Dec 2, 2024
@zimeg
Copy link
Member Author

zimeg commented Dec 2, 2024

@misscoded Thank you for the fast review!! :>

@zimeg zimeg merged commit 65c8955 into main Dec 2, 2024
4 checks passed
@zimeg zimeg deleted the zimeg-fix-prompt-channel-mrkdwn branch December 2, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misscoded misscoded misscoded approved these changes

Assignees

@zimeg zimeg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @misscoded