Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #507

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update README.md #507

merged 1 commit into from
Jan 30, 2024

Conversation

gjtorikian
Copy link
Contributor

Faraday::UploadIO has been deprecated for some time; this PR simply updates the README example to use the new class.

@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 7715866238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.169%

Files with Coverage Reduction New Missed Lines %
lib/slack/real_time/stores/store.rb 4 77.98%
lib/slack/real_time/concurrency/async.rb 28 1.39%
Totals Coverage Status
Change from base Build 6727999731: 0.002%
Covered Lines: 5055
Relevant Lines: 5669

💛 - Coveralls

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greggroth Thanks. Care to add a test that uses this class? This way we'd catch the deprecation next time.

@dblock dblock merged commit 5ffc654 into slack-ruby:master Jan 30, 2024
9 checks passed
@gjtorikian gjtorikian deleted the patch-1 branch January 30, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants