ENH Stream file merge task #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadorlhiac
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Thanks @valmar looks mostly good to me, I left a couple of comments inline. Two additional things:
- We should probably add validators to the
Taskmodel to:- Automatically pull the input directory from the output file of indexing (for now just CrystFEL)
- Set the output file accordingly
- Also, it is probably best to add a validator here now for the merge
Task:lute/lute/io/models/sfx_merge.py
Line 47 in ff26ea7
| infile: Path | ||
| for infile in stream_file_list: | ||
| with open(infile, "rb") as fd: | ||
| shutil.copyfileobj(fd, wfd) |
There was a problem hiding this comment.
Looks good to me. We should remember to pay attention to this when we start having interactions between multiple users. I remember we had some issues copying files and doing operations like this when multiple users were submitting jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a simple native task that merges several streams file into one by concatenating ther content.
Checklist
PR Type:
Address issues:
Testing