Fix/1560 tabs arent correctly marked for screen reader #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly-marked-for-screen-reader
…nning (partially working)
🦋 Changeset detectedLatest commit: b6b7a28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🕸 Website previewYou can view a preview here (commit |
🕸 Storybook previewYou can view a preview here (commit |
…orrectly-marked-for-screen-reader
jpzwarte
approved these changes
Nov 22, 2024
Diaan
reviewed
Nov 25, 2024
Diaan
approved these changes
Nov 27, 2024
packages/components/shared/src/mixins/observe-attributes-mixin.ts
Outdated
Show resolved
Hide resolved
jpzwarte
reviewed
Nov 28, 2024
anna-lach
deleted the
fix/1560-tabs-arent-correctly-marked-for-screen-reader
branch
Merged
|
Mixin improvement will be added in the future: #1652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.