Merge pull request #87 from offirt/patch-2

Modify Assistant - Take existing id from the state instead of the plan
skyscrapr · May 27, 2024 · a32166f · a32166f
2 parents 658b3c6 + 110c651
commit a32166f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/openai/assistant_resource.go b/openai/assistant_resource.go
@@ -233,11 +233,15 @@ func (r *AssistantResource) Update(ctx context.Context, req resource.UpdateReque
 	// Read Terraform plan data into the model
 	resp.Diagnostics.Append(req.Plan.Get(ctx, &data)...)
 
+	var state OpenAIAssistantResourceModel
+	// Read Terraform prior state data into the model
+	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
+
 	if resp.Diagnostics.HasError() {
 		return
 	}
 
-	tflog.Info(ctx, "Updating Assistant...")
+	tflog.Info(ctx, fmt.Sprintf("Updating Assistant: %s", state.Id.ValueString()))
 
 	aReq := openai.AssistantRequest{
 		Model:        data.Model.ValueString(),
@@ -257,7 +261,7 @@ func (r *AssistantResource) Update(ctx context.Context, req resource.UpdateReque
 	aReq.Tools = expandAssistantTools(toolModels)
 	aReq.ToolResources = expandAssistantToolResources(ctx, data.ToolResources)
 
-	assistant, err := r.client.Assistants().ModifyAssistant(data.Id.ValueString(), &aReq)
+	assistant, err := r.client.Assistants().ModifyAssistant(state.Id.ValueString(), &aReq)
 	if err != nil {
 		resp.Diagnostics.AddError("OpenAI Client Error", fmt.Sprintf("Unable to modify assistant, got error: %s", err))
 		return