internal: add CI checks for major Linux distros and fix build errors #2276
Conversation
nic11
force-pushed
the
pr-check-containers
branch
from
ee15a71 to
66bda12
Compare
Dockerfile
Outdated
| @@ -21,10 +21,7 @@ RUN useradd -m skymp | |||
| # It contains everything that should be installed on the system. | |||
| FROM skymp-runtime-base AS skymp-build-base | |||
|
|
|||
| # TODO: replace with a call to ubuntu2204? | |||
There was a problem hiding this comment.
Deliberately skipped Dockerfile for now to resolve in a separate PR
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 66bda12 in 35 seconds
More details
- Looked at
866lines of code in17files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_z4XN2IlISDWFQOYy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@Pospelove should the title be
? |
|
@ellipsis-dev update description |
|
Could you please provide more details on what specific updates you would like to see in the description? This will help me make the necessary changes accurately. |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f747f7b in 34 seconds
More details
- Looked at
852lines of code in17files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/script_storages/ScriptStorageUtils.cpp:3
- Draft comment:
Usingstd::regex_matchfor a simple file extension check is inefficient. Consider usings.ends_with(".pex")for better performance. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_wayOZpmN4w4UUi76
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nic11
changed the title
Important
Enhanced CI workflow with multi-distro support, improved build scripts, and minor code fixes.
.github/workflows/pr-ubuntu-docker.ymltopr-linux-variants.yml.pr-linux-variants.ymlincluding Ubuntu 22.04, 24.04, 24.10, Debian 12, and Arch Linux.misc/deps_linux/.build.shto dynamically set compilers based on availability.--clean-vcpkgand--print-envoptions tobuild.sh.<algorithm>and<cstdint>in several files includingWRLD.cpp,OpcodesImplementation.cpp,ActivateEvent.h,CustomEvent.h,EatItemEvent.h, andReadBookEvent.h.SimdJsonInputArchive::SerializeinSimdJsonInputArchive.hto satisfy GCC requirements.yarn.cmakefor better debugging.This description was created by
for f747f7b. It will automatically update as commits are pushed.