Remove display of SK in logs, disable hypervisor TLS by default.

cmd/skyconf/skyconf.go

@@ -100,7 +100,7 @@ func tempFile() (*os.File, error) {
 		return nil, err
 	}
 	name := filepath.Join(os.TempDir(), fmt.Sprintf("skyconf-%d-%d.log", os.Getpid(), time.Now().Unix()))
-	return os.OpenFile(name, os.O_WRONLY|os.O_CREATE, 0644)
+	return os.OpenFile(name, os.O_WRONLY|os.O_CREATE, 0644) //nolint:gosec
 }
 
 func makeLogger() (*log.Logger, *os.File) {

pkg/boot/params.go

@@ -199,9 +199,10 @@ func (bp Params) PrintEnvs(w io.Writer) error {
 		if err := PrintEnv(w, LocalPKENV, pk.String()); err != nil {
 			return err
 		}
-		if err := PrintEnv(w, LocalSKENV, bp.LocalSK.String()); err != nil {
-			return err
-		}
+		// TODO(evanlinjin): We may need to re-enable this in the future.
+		//if err := PrintEnv(w, LocalSKENV, bp.LocalSK.String()); err != nil {
+		//	return err
+		//}
 	}
 	if len(bp.HypervisorPKs) > 0 {
 		list := "("

pkg/prepconf/prepare.go

@@ -37,7 +37,7 @@ func Prepare(logger *log.Logger, conf Config, bp boot.Params) error {
 	ensureExists := func(name string, genConfig genFn) error {
 		//// Do nothing if file exists.
 		if _, err := os.Stat(name); err == nil {
-			conf, err := ioutil.ReadFile(name)
+			conf, err := ioutil.ReadFile(name) //nolint:gosec
 			if err == nil {
 				logger.Printf("Contents of %q: %q", name, string(conf))
 			}
@@ -171,8 +171,7 @@ func generateHypervisorConfig(conf Config, bp boot.Params) (interface{}, error)
 	out.DmsgDiscovery = skyenv.DefaultDmsgDiscAddr
 	out.DmsgPort = skyenv.DmsgHypervisorPort
 	out.HTTPAddr = ":8000"
-	out.EnableTLS = true
-	// TODO(evanlinjin): Pass filenames as cli args in 'skyconf'.
+	out.EnableTLS = false // TODO(evanlinjin): TLS is disabled due to a bug in the skyminer Router.
 	out.TLSCertFile = conf.TLSCert
 	out.TLSKeyFile = conf.TLSKey
 	err = GenCert(out.TLSCertFile, out.TLSKeyFile)