Downgrade circe and circe-yaml versions #53
Conversation
| @@ -116,4 +116,39 @@ class TopicConfigurationParserSpec extends BaseSpec { | |||
| TopicConfigurationParser(new StringReader(yml)).right.value shouldBe List.empty | |||
| } | |||
|
|
|||
| it should "parse topics configured using yaml anchors and aliases" in { | |||
There was a problem hiding this comment.
Feel like the second test covers this as well. Maybe just keep the second test?
There was a problem hiding this comment.
I agree, its unnecessary duplication. It would be great to have this as a property based test, but I'm not sure we use those in this project.
There was a problem hiding this comment.
Yeah happy to remove it from here. Do we think testing anchors/aliases at a higher level would be useful (e.g. KafkaConfiguratorIntSpec) or is showing that the parsing is working here enough?
There was a problem hiding this comment.
It could have value only as documentation, showing that we support it.
There was a problem hiding this comment.
I've removed this test and added on to KafkaConfiguratorIntSpec in 75222fb. Also updated the readme to mention that anchors can be used.
Relates to #52
This reverts part of #51 to remove the constraint on total number of yaml aliases that was introduced into snakeyaml. Hopefully we will be able to upgrade properly in the future once circe/circe-yaml#136 is resolved and we have a way to configure this maximum.