Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Alps SKDN Brown #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/switches/alps/alps/SKDN.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import {
Material,
SpringStainlessSteel,
type Switch,
} from '../../../switch';
import { Color, Force, Tolerance, Travel } from '../../../types';

export default {
model: 'SKDN Brown',
variation: '69g',
profile: 'regular',
stem: 'alps mount',
mount: 'alps',
Comment on lines +12 to +13
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to define ALPS stem, as I haven't defined it yet

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see how I did it for MX stem

type: 'tactile',
lifetime: 50,
lighting: 'none',
lubrication: 'none',
datasheet: undefined,
volume: undefined,
spring: SpringStainlessSteel.Regular('gold'),
housing: {
upper: Material.Unspecified(Color.Opaque(COLOR_OTHER)),
lower: Material.Unspecified(Color.Opaque(COLOR_OTHER)),
Comment on lines +22 to +23
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where COLOR_OTHER is defined

},
force: {
bottom: undefined,
actuation: Force.GramForce(60),
},
travel: {
pre: Travel.Millimeter(4.0, Tolerance.PlusMinus(0.2)),
total: undefined,
},
} satisfies Switch;
7 changes: 7 additions & 0 deletions src/switches/alps/alps/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { Brand } from '../../../switch';
import jadeGreen62g from './SKDN';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import jadeGreen62g from './SKDN';
import skdn from './SKDN';


export default {
name: 'Alps',
switches: [SKDN],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
switches: [SKDN],
switches: [skdn],

} satisfies Brand;
6 changes: 6 additions & 0 deletions src/switches/alps/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import type { CollectionInterface } from '../../collection';
import alps from './alps';

export default (collection: CollectionInterface): void => {
collection.add({ name: 'Alps', brands: [alps] });
};