[ENH] customizable special attrs in clone #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
fkiraly
added a commit
that referenced
this pull request
Nov 13, 2024
This PR refactors the current `_clone` logic, which had a lot of if/else case distinctions (as in the `sklearn` native code) to a list of plugins that can be extended. Above the refactor, it also adds a `sklearn` specific plugin that dispatches to `sklearn` clone, ensuring that configs get cloned as well. An approach to sktime/sktime#7333, which would be solved directly after update. An alternative to #380, with advantages: * `sklearn` compatibility is automatic, for any dependency of `skbase` * the plugins can later be extended easily, for instance in a case like the missing `dict` support A test for sktime/sktime#7333, namely that output configs are retained in `sklearn` objects, has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
clone_attrsconfig field which lets users specify a list of strings, attribute names which are retained inclonebeyond the configs and init parameters.This is by default
None, so retains current behaviour.An approach to sktime/sktime#7333, which would be solved if we set the
sklearnspecific attribute responsible forset_outputin this list, insktimeonly.The main drawback of this would be that
sklearncompatibility is not automatic, but contingent on setting this hard-to-find config.