[ENH] merge sktime BaseEstimator into skbase BaseEstimator
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
changed the title
sktime BaseEstimator into skbase BaseEstimatorsktime BaseEstimator into skbase BaseEstimator
fkiraly
added a commit
to sktime/sktime
that referenced
this pull request
Oct 18, 2024
This PR removes a leftover duplication from the `sktime`-to-`skbase` refactor - the content of the `sktime` `BaseEstimator` class. I have manually gone through the code step-by-step and verified equivalence. The only changes/differences were: * setting the `GET_FITTED_PARAMS_NESTING` attribute * changes in docstring formatting that were applied in `sktime` but not in `skbase` - I have moved these to a new PR in `skbase`, sktime/skbase#370 * `skbase` hase a safe "get fitted params" subroutine implemented, this is an improvemnet above `sktime` so does not need to be removed As a side issue, the `NotFittedError` in `sktime.exceptions` also needed to be replaced by the `skbase` one, to ensure tests and user code does not fail (due to different class identitites of two `NotFittedError`-s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges some minor improvements from
sktimeBaseEstimatorintoskbaseBaseEstimator:check_is_fittedcallsAccompanies sktime/sktime#7213, see there for explanation of merge and deduplication.