Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Fixed spelling mistakes as identified by codespell and typos #245

Merged
merged 3 commits into from
Nov 18, 2023
Merged

[MNT] Fixed spelling mistakes as identified by codespell and typos #245

merged 3 commits into from
Nov 18, 2023

Conversation

yarnabrina
Copy link
Member

Commands used:

  1. codespell --write-changes .
  2. typos --locale en --write-changes

Anirban Ray added 2 commits November 14, 2023 21:34
typos --locale en --write-changes .
@yarnabrina yarnabrina requested a review from fkiraly November 14, 2023 16:15
@yarnabrina
Copy link
Member Author

@fkiraly I interpreted from sktime/sktime#5502 (review) that skbase has methodd typo as well, but I could not find. Did you mean something else?

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12a1884) 84.19% compared to head (e588807) 84.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          43       43           
  Lines        2891     2891           
=======================================
  Hits         2434     2434           
  Misses        457      457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly
Copy link
Contributor

fkiraly commented Nov 18, 2023

@fkiraly I interpreted from sktime/sktime#5502 (review) that skbase has methodd typo as well, but I could not find. Did you mean something else?

Looks like I already fixed it there, the names are method_shallow and method_public.

Copy link
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, although I am tempted leaving artifcats. Can't have enough cats.

@fkiraly fkiraly added the code quality Code formatting and quality label Nov 18, 2023
@yarnabrina yarnabrina merged commit 2f91a7b into sktime:main Nov 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code formatting and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants