Add logo support and "&" for authors #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcroce
changed the title
|
hi, thanks for the PR. I like the general idea of adding a logo option, and the new & is also very good. But due to the changes, the author string moved up and is not in the corner anymore like in the original design. And the logo is not well positioned, it does not have the same distance from the colored rectangle on the top and the page margin. Ive added an image of what i mean. If you can fix these, i will gladly take the PR. Otherwise ill try my luck. Thanks again:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the "and" with "&" in order to be used in multiple languages and add the possibility to insert a logo on the title page.