Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore n8n child dependencies (N8N-6) #117

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

MaSpeng
Copy link
Contributor

@MaSpeng MaSpeng commented Jun 7, 2024

This pull request will add the dependencies n8n-nodes-base and n8n-workflow to the dependabot ignore list as we need to manually pin them to the same version which is requested by n8n itself.

@MaSpeng MaSpeng requested a review from schroedan June 7, 2024 11:09
@schroedan
Copy link
Contributor

So we should check (at pull request) if the versions of these dependencies in every package.json satisfy the version of npm view n8n-nodes-base version and npm view n8n-workflow version?

@MaSpeng
Copy link
Contributor Author

MaSpeng commented Jun 7, 2024

No, we don't check anything at the pull request level.

Whenever we receive a pull request from dependabot for n8n it always requires manual work.

  1. we need to determine the node version that the target version of n8n is natively using (from the docker image)
  • this version needs to be manifested in the devcontainer and all affected GitHub workflows
  • the respective types need to be manifested in the repository dependencies (sadly they often do not match with the node version)
  1. we need to determine which version of n8n-nodes-base and n8n-workflow is the target version of n8n is using
  • these version needs to be manifested in the repository dependencies due to the known compatibility issues
  • these versions need to be manifested in each nx project (custom node)
  • a distinct commit in the structure fix(<nx project name>): <commit message> (<reference>) has to be made, to allow nx to do its work when we want to create a new release for each custom node

We surely could automate this process in the CI but I think it would be quite a large workflow and would contain some barriers to overcome, for example, the evaluation of the node version of the docker image, or even finding out which version n8n uses for n8n-base-nodes and n8n-workflow.

This PR aims to reduce the unnecessary noise about pre-release versions we cannot use anyway.

@schroedan schroedan merged commit b4ff805 into main Jun 10, 2024
4 checks passed
@schroedan schroedan deleted the N8N-6-ignore-n8n-child-dependency-updates branch June 10, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants