Merge pull request #7 from skolemlabs/fix/cflags-and-ci

fix: remove empty c/library flags and add CI

.github/workflows/main.yml

@@ -0,0 +1,34 @@
+name: CI
+
+on:
+  - push
+
+jobs:
+  build:
+    name: Build and test
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu-latest
+        ocaml-version:
+          - 4.12.1
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@master
+
+      - name: Use OCaml ${{ matrix.ocaml-version }}
+        uses: avsm/setup-ocaml@v2
+        with:
+          ocaml-compiler: ${{ matrix.ocaml-version }}
+          opam-depext: false
+          opam-pin: false
+
+      - run: opam pin add mysql8.dev -n .
+      - run: opam depext -yt mysql8
+      - run: opam install -t . --deps-only
+      - run: opam exec -- dune build

CHANGES

@@ -1,3 +1,7 @@
+* Sat Dec 18 2021 (1.2.6)
+  * Filter empty C/library flags from `mysql_config`
+  * Add Github Actions-based CI
+
 * Fri Dec 17 2021 (1.2.5)
   * Add library path fixes for brew for openssl library linking
 

src/config/discover.ml

@@ -35,12 +35,14 @@ let mysql_config_path =
 let c_flags =
   match execute_with_output (mysql_config_path ^ " --cflags") with
   | Some str ->
-    String.split_on_char ' ' str @ [ "-fPIC" ]
+    String.split_on_char ' ' str @ [ "-fPIC" ] |> List.filter (( <> ) "")
   | None -> []
 
 let libs =
   match execute_with_output (mysql_config_path ^ " --libs") with
-  | Some str -> String.split_on_char ' ' str @ [ "-L/usr/local/opt/openssl/lib/" ]
+  | Some str ->
+    String.split_on_char ' ' str @ [ "-L/usr/local/opt/openssl/lib/" ]
+    |> List.filter (( <> ) "")
   | None -> []
 
 let replace_exact rep _with str =