Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator filter #3

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Generator filter #3

merged 4 commits into from
Nov 28, 2023

Conversation

novotnyJiri
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for pull request!!!
hey @JiriNovotny @obabec

obabec
obabec reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@obabec obabec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that testing with just one column of variable length is not really great for testing default. We should stick with some bigger tables that will generate us load as close to real-life use case. But this could be nice for specific test cases.

@novotnyJiri novotnyJiri merged commit dbb405d into main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obabec obabec obabec approved these changes

Assignees

@novotnyJiri novotnyJiri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novotnyJiri @obabec