Correcting normalization #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the variable normalize gets the value False when the user specifies vmin and vmax.
vmin and vmax can be defined when using
mp.plot(..., shading = {"normalize" = [vmin, vmax]}, ...)
If nothing is set by the user the standard value is
"normalize" = [None, None].
If any of the two entries are None, then the variable normalize in Viewer.py gets the value True, and vmin and vmax are chosen inside utils.py in get_colors.
We don't need the variable normalize, since the condtion in get_colors can be written based on vmin and vmax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to set vmin and vmax for normalization of the cmap.
With this changes, now it is possible to choose those values when setting shading = {"normalization": [vmin, vmax]}
inside plot or subplot.
The solution given in #41 works only for the case of choosing vmin and vmax, and would fail when the user wants
vmin and vmax to be set automatically.