Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Fix broken Playground link in topnav #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jseldess
Copy link

@jseldess jseldess commented Sep 21, 2023

Description

This PR removes a trailing slash for the Playground link in the website topnav.

Motivation and Context

That trailing slash was adding index.html to the url, causing the url to 404.

How Has This Been Tested?

Tested this locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/

The "Playground" link 404s due to a trailing slash
that adds index.html to the url. The PR removes
that trailing slash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant