example-and-external-config #153
Conversation
| @@ -2,3 +2,6 @@ | |||
| to: <%= h.src() %>/<%= h.changeCase.lower(name) %>/.stylelintignore | |||
| --- | |||
| /color/*.css | |||
| node_modules/**/*.css | |||
There was a problem hiding this comment.
This seems useless, because stylelint already ignoring node_module's css (at least it should from what i know)
There was a problem hiding this comment.
Ok. I will remove this.
packages/kaizen-tg/_templates/drupal-9-theme/new/.stylelintignore
Outdated
Show resolved
Hide resolved
packages/kaizen-tg/_templates/drupal-9-theme/new/packages/components/_typography.css
Show resolved
Hide resolved
packages/kaizen-tg/_templates/drupal-9-theme/new/packages/components/_typography.css
Show resolved
Hide resolved
| src: | ||
| local(""), | ||
| url("../../fonts/ExampleFont.woff2") format("woff2"), | ||
| url("../../fonts/ExampleFont.woff") format("woff"); |
There was a problem hiding this comment.
no need for woff already
| @@ -0,0 +1,4 @@ | |||
| /* uncomment next line to import css file external */ | |||
There was a problem hiding this comment.
I'm not sure we have to keep it in kaizen. It's not obvious at all for what this file created. Instead - you have to fix ugly bugs and unpredictible behaviors rather than provide some hacks which are clear only to you
There was a problem hiding this comment.
if we need to include the external CSS files from the library without changing, this is the way to include this without linter check and include this from ONE place. Not in different files from node_modules. If we change something in the component structure we don't need to change it somewhere also. Becasue all files and styles are came from component.
| /* uncomment next line to import css file external */ | ||
| /* @import "@themeName/components/component_example_external"; */ | ||
|
|
||
| /* stylelint-enable */ |
There was a problem hiding this comment.
This comment is for /static-files/logo.svg file - why it exist here? We already have a logo in theme dir
artreaktor-niks
force-pushed
the
example-and-external-config
branch
2 times, most recently
from
02d79ae to
90f1fcb
Compare
|
Removed most of solutions. |
artreaktor-niks
force-pushed
the
example-and-external-config
branch
from
90f1fcb to
6eab55b
Compare
|
please update version, and i'll publish |
artreaktor-niks
force-pushed
the
example-and-external-config
branch
from
6eab55b to
8e4cdd9
Compare
Updated. |
Added changes:
"Static-files" folder for Storybook. Inside this folder we could place logo files and so on - and URL inside twig files will be directly, for example:
<img src="static-files/logo.svg" />There is an example of how to add CSS from an external library and for linter exclusion for this file.
added commented code - to add font files.