Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is the same PR as for Macaw's Trapdoors, except for Macaw's Doors)
In Minecraft 1.19.2 (and likely every other version), picking up any item immediately unlocks all recipes added by this mod. This is unintentional, since the advancements specify only certain items should unlock it. This PR fixes that.
According to the Minecraft wiki, the objects in the conditions.items array should contain a key named "items", not "item", whose value is an array of strings, not a single string.
These changes were made automatically using the following command in the Zsh shell on Linux (macOS's BSD variant of sed doesn't support the -i option as used here):
sed -i -E 's/"item": (.+)/"items": [\1]/' /advancements//*.json
You should be able to use this command to make the same changes to the rest of your mods; I have submitted PRs for only those mods I am personally using :)