Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe unlock condition #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ForgottenUmbrella
Copy link

(This is the same PR as for Macaw's Trapdoors, except for Macaw's Doors)

In Minecraft 1.19.2 (and likely every other version), picking up any item immediately unlocks all recipes added by this mod. This is unintentional, since the advancements specify only certain items should unlock it. This PR fixes that.

According to the Minecraft wiki, the objects in the conditions.items array should contain a key named "items", not "item", whose value is an array of strings, not a single string.

These changes were made automatically using the following command in the Zsh shell on Linux (macOS's BSD variant of sed doesn't support the -i option as used here):

sed -i -E 's/"item": (.+)/"items": [\1]/' /advancements//*.json

You should be able to use this command to make the same changes to the rest of your mods; I have submitted PRs for only those mods I am personally using :)

@sketchmacaw
Copy link
Owner

Oh my god! I couldn't for the world figure out why it does it, and this is why? I had to be blind to not see this, thank you so so so much! Will implement this in every mod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants