Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pyinstaller release errors #111

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 50 additions & 54 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: release

on:
push:
tags:
- v[0-9]+.[0-9]+.?[0-9]*
on: push

jobs:
build:
Expand All @@ -13,19 +10,19 @@ jobs:
- os: linux
arch: x86_64
runs: ubuntu-latest
ext: ''
ext: ""
- os: windows
arch: x86_64
runs: windows-latest
ext: '.exe'
ext: ".exe"
- os: macos
arch: x86_64
runs: macos-12
ext: ''
ext: ""
- os: macos
arch: arm64
runs: macos-14
ext: ''
ext: ""

runs-on: ${{ matrix.runs }}
steps:
Expand All @@ -34,17 +31,17 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.11'
python-version: "3.11"
architecture: x64 # Otherwise the runner will try to download Python arm64, which is not available. x64 has support for both archs (universal2).
- name: Install latest stable
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
toolchain: stable
override: true
- name: Build
run: |
python -m pip install --upgrade pip
pip install pyinstaller
pip install "pyinstaller>=5.12"
pip install certifi
pip install maturin
pip install .[fast]
Expand All @@ -56,18 +53,18 @@ jobs:
- name: zip release
uses: thedoctor0/zip-release@main
with:
type: 'zip'
filename: 'fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip'
directory: 'dist'
path: '*'
type: "zip"
filename: "fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip"
directory: "dist"
path: "*"
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: builds
path: dist/fig2sketch-${{ matrix.os }}-${{ matrix.arch }}.zip

build-macos-universal:
needs: [ build ]
needs: [build]
runs-on: macos-latest
steps:
- name: Download artifact
Expand Down Expand Up @@ -97,47 +94,46 @@ jobs:
- name: zip release
uses: thedoctor0/zip-release@main
with:
type: 'zip'
filename: 'fig2sketch-macos-universal.zip'
directory: 'dist'
path: '*'
type: "zip"
filename: "fig2sketch-macos-universal.zip"
directory: "dist"
path: "*"
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: builds
path: dist/fig2sketch-macos-universal.zip

# create-release:
# needs: [build, build-macos-universal]
# runs-on: ubuntu-latest
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# steps:
# - name: Download artifacts
# uses: actions/download-artifact@v3
# with:
# name: builds
# - uses: ncipollo/release-action@v1
# with:
# artifacts: "fig2sketch-*.zip"
# generateReleaseNotes: true

create-release:
needs: [ build, build-macos-universal ]
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- name: Download artifacts
uses: actions/download-artifact@v3
with:
name: builds
- uses: ncipollo/release-action@v1
with:
artifacts: "fig2sketch-*.zip"
generateReleaseNotes: true

publish-to-pypi:
name: Build and publish to PyPi
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: '3.11'
- name: Install build tools
run: pip install build
- name: Build source distribution
run: python -m build --sdist
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API_TOKEN }}
# publish-to-pypi:
# name: Build and publish to PyPi
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@master
# - name: Set up Python
# uses: actions/setup-python@v3
# with:
# python-version: "3.11"
# - name: Install build tools
# run: pip install build
# - name: Build source distribution
# run: python -m build --sdist
# - name: Publish to PyPI
# uses: pypa/gh-action-pypi-publish@release/v1
# with:
# password: ${{ secrets.PYPI_API_TOKEN }}
Loading