fix(avatar): remove unecessary h-full class in Avatar fallbackBase #3240
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AppBar with initials only.
Bugfix/avatar remove unecessary h-full class
fix(changeset): remove duplicated changeset doc
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GabrielPaliari is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
GabrielPaliari
changed the title
|
@nullpointerexceptionkek Sorry for the struggle. I think now, maybe, its right |
endigo9740
requested changes
Feb 22, 2025
There was a problem hiding this comment.
Hi @GabrielPaliari thanks for the PR. Just one quick change. If you can make that this is good to merge. Thanks for your contribution!
endigo9740
merged commit 5c68238
into
skeletonlabs:changeset-release/next
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #2408
Description
This PR fixes the bug of avatar component with initials only that causes content to load in the center of screen, when used in AppBar. In fact ive just removed unecessary h-full class in fallbackrender
OBS: I didnt manage to replicate the bug, cause i dont have Safari. (I tried BrowserStack but coudnt reproduce as well). @nullpointerexceptionkek tried too and didn't succeed. Since is a trivial fix, i will submit the PR anyway. Tell if we need some other test.
Checklist
Please read and apply all contribution requirements.
devbranch (NEVERmaster)docs/,feat/,chore/,bugfix/pnpm ci:checkpnpm formatpnpm test