Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): fix avatar bug, rendering improperly in appbar #3239

Conversation

GabrielPaliari
Copy link

Linked Issue

Closes #2408

Description

This PR fixes the bug of avatar component with initials only that causes content to load in the center of screen, when used in AppBar.
OBS: I didnt manage to replicate the bug, cause i dont have Safari. (I tried BrowserStack but coudnt reproduce as well). @nullpointerexceptionkek tried too and didn't succeed. Since is a trivial fix, i will submit the PR anyway. Tell if we need some other test.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: 3ae97a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Feb 22, 2025 4:38am

Copy link

vercel bot commented Feb 22, 2025

@GabrielPaliari is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@nullpointerexceptionkek
Copy link
Contributor

@GabrielPaliari Why are you merging into change-set/next?

@GabrielPaliari
Copy link
Author

@nullpointerexceptionkek, ive created the pr. Could you test, please? Is a changeset realy necessary in this case? If so i could create one.

@nullpointerexceptionkek
Copy link
Contributor

nullpointerexceptionkek commented Feb 22, 2025

First of all, @GabrielPaliari You should merge into next.

Please close this PR and merge it into the next branch instead.

You will need to run pnpm changeset for this

@GabrielPaliari
Copy link
Author

Thank you @nullpointerexceptionkek, i am closing this to merge into next, run changeset and then generate a new PR. Sorry for the trouble.

@GabrielPaliari GabrielPaliari deleted the bugfix/avatar-appbar-render branch February 22, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants