Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next: Add Switch Component #2698

Merged
merged 21 commits into from
Jun 3, 2024
Merged

Next: Add Switch Component #2698

merged 21 commits into from
Jun 3, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented May 29, 2024

Linked Issue

Closes #2394

Description

Add the Switch component for both Svelte and React, as well as all standard documentation.

NOTE: also installs Lucide-Svelte and Lucide-React for testing icons!

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 2812ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton-svelte Minor
@skeletonlabs/skeleton-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:35pm
skeleton-themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:35pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:35pm

@endigo9740 endigo9740 marked this pull request as ready for review May 31, 2024 20:50
@endigo9740
Copy link
Contributor Author

endigo9740 commented Jun 3, 2024

Remaining tasks:

  • Convert <button> to type button

NOTE: bumping this to a dedicated pass for all existing and upcoming components:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant