Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom enhancements #2012

Closed

Conversation

thomascarman
Copy link

Linked Issue

Closes #2011

Description

Add Option to Custom Theme for enhancements for custom css.

Changsets

"skeleton.dev": minor

"@skeletonlabs/tw-plugin": minor

feat:Add Enhancements feature to Custom Themes

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Sep 8, 2023 8:10am

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

🦋 Changeset detected

Latest commit: dcf2ea5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
skeleton.dev Minor
@skeletonlabs/tw-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endigo9740 endigo9740 marked this pull request as draft September 8, 2023 21:18
@endigo9740 endigo9740 marked this pull request as ready for review September 8, 2023 21:18
@endigo9740
Copy link
Contributor

@thomascarman after reviewing with @AdrianGonz97, I think we like the idea, but per the discussion in the main thread, this is a topic we're still exploring. We're going to close out the PR, but will keep the issue open for future reference. Even closed, we still still reference this PR as well.

Thanks!

@endigo9740 endigo9740 closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements on Custom Themes
2 participants