Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to lock colors in theme generator #1927

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ak4zh
Copy link
Contributor

@ak4zh ak4zh commented Aug 23, 2023

Linked Issue

Closes #1888 (issue was already closed but not implemented)

Description

This pull request introduces a new feature that allows users to lock colors from randomization in the theme generator. The purpose of this pull request is to enhance the theme generation process by giving users more control over specific colors.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: da0fbbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skeleton.dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 23, 2023 9:52am

@ak4zh ak4zh marked this pull request as ready for review August 23, 2023 09:52
@ak4zh
Copy link
Contributor Author

ak4zh commented Aug 23, 2023

We need to review the accessibility rating part a bit, it seems the emoji is not centered.

Screenshot 2023-08-23 at 3 26 08 PM

@niktek niktek mentioned this pull request Aug 23, 2023
32 tasks
@niktek niktek merged commit edbe0c0 into skeletonlabs:v2 Aug 23, 2023
@niktek
Copy link
Contributor

niktek commented Aug 23, 2023

Hi @ak4zh ,

Looks like we have a rendering issue for Firefox@latest with the lock not showing - can you pleas have a look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants