-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: useFocus
hook
#99
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tests are still failing, this is being looked into. They're only failing in CI... 😄 |
I honestly don't know why CI is failing, if anyone could clone the repo and confirm tests are running locally just fine that would be great:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hugos68 A few odds and ends, otherwise LGTM.
A couple things of note:
- I know you're working through the test cases, but it's extremely hard to review the PR when so many extra files are edited.
- The
/utils
directory is kind of blowing up. Consider grouping similar utils. I know it differs from Floating UI, but it's getting a bit crazy! - I'll do further testing when we implement in a practical example.
This reverts commit 1d58fac.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I made a few revisions to the doc page (just added/updated some text)
I requested a small update to the CodeBlock component, which will improve this page. But that should be a separate follow up PR:
Also note the CI / tests
checks are failing.
Once the latter are resolved it should be good to merge.
Linked Issue
Closes #5
Description
Adds the
useFocus
hook, tests for it and docs.Changesets
We use Changesets to automatically create our changelog per each release. Any changes or additions to the Library assets in
/lib
must be documented with a new Changeset. This can be done as follows:pnpm changeset
to trigger the Changeset CLI.minor
orpatch
. Nevermajor
.feature:
,chore:
orbugfix:
..md
files are added to the/.changeset
directory.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)pnpm format
pnpm lint
pnpm test