Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for CBF-Pipelines integration testing #801

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for CBF-Pipelines integration testing #801

wants to merge 3 commits into from
+17 −10

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Mar 12, 2025

Various fixes for the use case where the input for Pipelines comes from gpucbf.baseline-correlation-products output streams in the same subarray product, rather than from external sources.

  • Gracefully handle the case where we have a cam.http stream but no cbf.* streams and hence don't actually need to fetch any sensors at startup.
  • Pass along antennas that are inputs to gpucbf.antenna-channelised-voltage streams to cam2telstate.
  • Be more aggressive about making other tasks wait for cam2telstate to read initial values: assume that anything that uses telstate might want to use the initial values populated by cam2telstate. That could slow down subarray activation a little.

bmerry added 3 commits March 12, 2025 10:05
@bmerry
Fix exception when cam.http specified but no CBF inputs
99bc609 
It tries to query zero sensors, which because of the workarounds for
katportalclient, raises an exception.
@bmerry
Pass receptors from gpucbf.antenna-channelised-voltage streams to cam…
3da250a 
…2telstate

For testing (NGC-1551).
@bmerry
Rework how tasks wait for cam2telstate
5276c0f 
Instead of making input SPEAD streams special, just make any task that
uses telstate wait for cam2telstate. In theory this may be sub-optimal
since some tasks may use telstate but not need cam2telstate to start up
first, but I'm not expecting a major impact in startup time since most
tasks will have indirect dependencies anyway.

This fixes ingest starting without cam2telstate when they get their data
from gpucbf.baseline_correlation_products streams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludwigschwardt ludwigschwardt ludwigschwardt approved these changes

@richarms richarms Awaiting requested review from richarms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmerry @ludwigschwardt