Fix comments pr88 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exclude Flake8 config - exclude scratchpad personal stuff - exclude sqlite db files
- Fix issue calling pynetdicom apps - Add vscode config to .gitgnore
- Make ExplicitVRLittleEndian default transfer syntax - Modify RTSUMREC abbreviation
sjswerdloff
approved these changes
Jan 3, 2025
| @@ -48,11 +49,20 @@ def setUpClass(cls): | |||
| cls.invalid_xfer_syntaxes = [ | |||
| xfer for xfer, is_valid in XFER_SYNTAXES.items() if not is_valid] | |||
|
|
|||
| # Create the list of default transfer syntaxes | |||
There was a problem hiding this comment.
This looks like a candidate for refactoring for re-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request addresses reviewers comments in #88.
It modifies cstorescp.py to have ExplicitVRLittleEndian as default transfer syntax and modifies Treatment Summary Record 2 letters acronym to 3 letters.
It also updates CStoreSCP class tests and fix an issue in the integration test when run under Windows.