Refact echoscp #87
Merged
Refact echoscp #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjswerdloff
requested changes
Dec 15, 2024
tdwii_plus_examples/cli/echoscp.py
Outdated
There was a problem hiding this comment.
do we want to add a test of the cli version in the future?
The underlying class is getting tested, so I don't think it's critical unless the cli version is intended to get significant use.
There was a problem hiding this comment.
I will have to do it for the next steps cli apps so I will add it at the same time.
Change test class to TestCEchoSCP
sjswerdloff
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request addresses part of issue #85.
It refactors echoscp.py from the tdwii_plus_examples/TDWII_PPVS_subscriber folder.
The EchoSCP class is refactored as CEchoSCP and moved to tdwii_plus_examples package folder in cechoscp.py
The main function is refactored as an echoscp.py CLI application and moved to the tdwii_plus_examples/cli folder.