Add domain model #71
Merged
Add domain model #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initially generated by Claude 3.5 Sonnet, but significant corrections required and will still be required this is just to get it set in a branch so I can get back to other work
domain models for all known IODs and Sequences in DICOM 2024, generated based on innolitics standard/*.json files
…ard 2024 that aren't yet in pydicom
|
Claude generated classes didn't work. I wrote my own code generator and overwrote what I got from Claude. Although I did use Claude to help me tweak the specific code content (vs. constructing the object tree and visiting it, which was based on AnyTree and the innolitics/dicom-standard json files). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pydicom provides a great generic model for DICOM datasets, I find it more convenient to work with a domain model that represents the IODs and Sequences. This allows one to take advantage of property based code completion (a.k.a. "Intellisense").
The IODs and sequences were created using code generation based on the json files that the innolitics DICOM project creates
https://github.com/innolitics/dicom-standard/tree/master/standard
With some manual post processing to eliminate duplicates.
There are still some aspects that need to be tidied up where the same sequence contains different elements in different IODs or just in different parent sequences.
The code generator for the domain model will be placed in a separate project/repo
The domain model was used to model the RT Ion Plan and RT Ion Beams Treatment Records IODs to assist in synthesising "perfectly delivered" treatment records from a plan. Those treatment records are intended to be used in the TDW-II workflow as one of the final steps (Store Treatment Delivery Results to OST [RO-63]).