Add image refs to ups #49
Conversation
… setup image sequence items to InputInformationSequence
…o and setup images default GUI is to not include default command line is to include
| ) | ||
| patient_photo_reference_items.append(patient_photo_reference_item) | ||
|
|
||
| # This makes the assumption that the Study and Series Instance UIDs for the Setup images are the same as the plan |
There was a problem hiding this comment.
with different modalities for the RT Plan and the RT Images, this can actually never be right.
There was a problem hiding this comment.
Excellent point, re Series Instance UID.
That makes for an interesting issue for referenced objects that only have instance level references... The scheduler needs to retrieve the object using a relational query so it can construct the navigational reference.
I'll back out the setup image part for now and address those and RT Image references in a separate PR.
Thank you for the useful feedback.
There was a problem hiding this comment.
You are welcome. But I am not aware that any archive has implemented relational queries. So, how is this supposed to work in general for UPSs when there is only the Instance Information?
For most of the composite IODs there is the Common Instance Reference Module that provides the hierarchical information for the plain instance references in an instance...
There was a problem hiding this comment.
Updated to search in the Common Instance Reference Module (available in RT (Ion) Plan), and if the Study and Series UID for those referenced instances are not found, avoid encoding in the Input Information sequence.
… images) in the common instance reference module do not make assumptions about study and series UIDs if and only if the study and series uids for the referenced sop instance UID are present, encode in the InputInstanceSequence
| @@ -74,7 +74,7 @@ def _bdidir_button_clicked(self): | |||
| dialog.setFileMode(QFileDialog.Directory) | |||
| dialog.setOption(QFileDialog.ShowDirsOnly, True) | |||
| dialog.setLabelText(QFileDialog.Accept, "Select") | |||
| if dialog.exec_() == QFileDialog.Accepted: | |||
| if dialog.exec() == QFileDialog.Accepted: | |||
There was a problem hiding this comment.
addresses a deprecation warning generated by PySide6
addresses part of #48 (patient photo and setup photos, but not DRRs referenced in Beams, i.e. setup DRRs or portals).