Reformat with black, cleanup based on flake8 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration json file (ApplicationEntities.json)
reformatted with isort --profile black
using treatment_delivery_type in rtbdi_factory (real bug caught by flake8) instead of hardcoded TREATMENT
|
oh... and updated to use configuration files for AE IP address and ports rather than being hardcoded... |
sjswerdloff
commented
May 4, 2024
…or have per file excludes and the entire repo has been tidied
sjswerdloff
commented
May 4, 2024
celeron533
reviewed
May 5, 2024
celeron533
reviewed
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran:
black -l 127and
poetry run flake8 --count --exit-zero --extend-ignore=E203 --max-line-length=127 --statistics --per-file-ignores="tdwii_plus_examples/rtbdi_creator/ui_form.py:E266,F401,E501 tdwii_plus_examples/TDWII_PPVS_subscriber/ui_tdwii_ppvs_subscriber.py:E266,F401,E501" tdwii_plus_examplesThe ui*.py files are generated by Qt Creator and are not intended to have manual edits (they will be overwritten when changes are made in Qt Creator) so there isn't much to be done about the generated code.
incorporated the flake8 above, but enforcing during build by removing the --exit-zero.