🚑 Fix no values not making page (#8)

sjquant · Mar 14, 2024 · 2f80eca · 2f80eca
1 parent 8cef3fa
commit 2f80eca
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/sitemapr/core.py b/sitemapr/core.py
@@ -117,7 +117,7 @@ def _get_param_combinations(
             return [{}]
 
         combinations: list[dict[str, str]] = []
-        for values in product(*[param.values for param in params]):
+        for values in product(*[param.values for param in params if param.values]):
             combination = {
                 param.name: value for param, value in zip(params, values, strict=False)
             }

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -26,6 +26,14 @@ def test_iter_url_works():
             path="/blog/{id}",
             path_params=[Param(name="id", values=["1", "2", "3"])],
         ),
+        Page(
+            path="/blog/{id}/comments",
+            path_params=[Param(name="id", values=["1", "2"])],
+            query_params=[
+                Param(name="page", values=[]),
+                Param(name="sort", values=["asc", "desc"]),
+            ],
+        ),
     ]
     sitemapr = SiteMapr(base_url=base_url, pages=pages)
 
@@ -124,6 +132,30 @@ def test_iter_url_works():
             changefreq=None,
             priority=None,
         ),
+        SiteMapUrl(
+            loc="https://example.com/blog/1/comments?page=asc",
+            lastmod=None,
+            changefreq=None,
+            priority=None,
+        ),
+        SiteMapUrl(
+            loc="https://example.com/blog/2/comments?page=asc",
+            lastmod=None,
+            changefreq=None,
+            priority=None,
+        ),
+        SiteMapUrl(
+            loc="https://example.com/blog/1/comments?page=desc",
+            lastmod=None,
+            changefreq=None,
+            priority=None,
+        ),
+        SiteMapUrl(
+            loc="https://example.com/blog/2/comments?page=desc",
+            lastmod=None,
+            changefreq=None,
+            priority=None,
+        ),
     ]
     assert actuals == expected