Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): downgrade node from v21 to v20 #61

Merged
merged 5 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
uses: actions/checkout@v4

# Set version of node to use
- name: Use Node.js 21
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 21.x
node-version: 20.x

# This command is similar to npm install, except it's meant to be used in
# automated environments such as test platforms, continuous integration,
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
uses: actions/checkout@v4

# Set version of node to use
- name: Use Node.js 21
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 21.x
node-version: 20.x

# This command is similar to npm install, except it's meant to be used in
# automated environments such as test platforms, continuous integration,
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/snyk_container-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ jobs:
with:
image: sjmayotte/route53-dynamic-dns
args: --file=Dockerfile
# Related to snyk issue: https://github.com/github/codeql-action/issues/2187
- name: Replace security-severity null for license-related findings
run: >
sed -i 's/"security-severity": "null"/"security-severity": "0"/g' snyk.sarif
- name: Upload result to GitHub Code Scanning
uses: github/codeql-action/upload-sarif@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Use offical Node.js image. The image uses Apline Linux
FROM node:21.7.0-alpine
FROM node:20.12.2-bookworm-slim

# Build-time metadata as defined at https://github.com/opencontainers/image-spec/blob/master/annotations.md
ARG BUILD_DATE
Expand All @@ -10,7 +10,7 @@ ARG GIT_SHA
ENV NODE_ENV production

# Install timezone database to allow setting timezone through TZ environment variable
RUN apk add --no-cache tzdata
RUN apt install tzdata

LABEL org.opencontainers.image.created=$BUILD_DATE \
org.opencontainers.image.authors="Steven Mayotte" \
Expand Down
Loading