Fix clang-tidy warnings about includes

.clang-tidy

@@ -6,7 +6,6 @@ Checks: "-*,\
   google-readability-casting,\
   misc-*,\
   -misc-non-private-member-variables-in-classes,\
-  -misc-include-cleaner,\
   -misc-const-correctness,\
   modernize-*,\
   -modernize-avoid-c-arrays,\

CMakeLists.txt

@@ -233,7 +233,7 @@ else()
 
     if(CLANG_TIDY)
       message(STATUS "Activate clang-tidy")
-      set(CMAKE_CXX_CLANG_TIDY "clang-tidy")
+      set(CMAKE_CXX_CLANG_TIDY clang-tidy)
     else()
       message(FATAL_ERROR "clang-tidy executable cannot be found")
     endif()

src/api-objects/include/tradedamounts.hpp

@@ -26,7 +26,7 @@ struct TradedAmounts {
     return *this;
   }
 
-  bool operator==(const TradedAmounts &) const = default;
+  constexpr bool operator==(const TradedAmounts &) const = default;
 
   friend std::ostream &operator<<(std::ostream &os, const TradedAmounts &tradedAmounts);
 

src/api-objects/src/tradedamounts.cpp

@@ -1,5 +1,9 @@
 #include "tradedamounts.hpp"
 
+#include <ostream>
+
+#include "cct_string.hpp"
+
 namespace cct {
 
 string TradedAmounts::str() const {

src/api/common/src/exchangeprivateapi.cpp

@@ -1,15 +1,51 @@
 #include "exchangeprivateapi.hpp"
 
+#include <algorithm>
 #include <chrono>
+#include <cstdint>
+#include <limits>
 #include <map>
+#include <optional>
+#include <span>
+#include <string_view>
 #include <thread>
+#include <tuple>
+#include <utility>
 
+#include "apikey.hpp"
+#include "balanceoptions.hpp"
+#include "balanceportfolio.hpp"
+#include "cct_log.hpp"
 #include "cct_vector.hpp"
 #include "coincenterinfo.hpp"
+#include "currencycode.hpp"
+#include "deposit.hpp"
+#include "depositsconstraints.hpp"
+#include "exchangebase.hpp"
+#include "exchangeinfo.hpp"
+#include "exchangename.hpp"
+#include "exchangeprivateapitypes.hpp"
+#include "exchangepublicapi.hpp"
+#include "exchangepublicapitypes.hpp"
+#include "market.hpp"
+#include "marketorderbook.hpp"
+#include "monetaryamount.hpp"
+#include "monetaryamountbycurrencyset.hpp"
+#include "orderid.hpp"
+#include "priceoptions.hpp"
+#include "priceoptionsdef.hpp"
 #include "recentdeposit.hpp"
 #include "timedef.hpp"
+#include "tradedamounts.hpp"
+#include "tradedefinitions.hpp"
+#include "tradeinfo.hpp"
+#include "tradeside.hpp"
 #include "unreachable.hpp"
+#include "withdraw.hpp"
+#include "withdrawinfo.hpp"
 #include "withdrawoptions.hpp"
+#include "withdrawordeposit.hpp"
+#include "withdrawsconstraints.hpp"
 
 namespace cct::api {
 

src/api/common/test/exchangepublicapi_test.cpp

@@ -3,13 +3,24 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
+#include <optional>
+
 #include "cct_const.hpp"
 #include "cct_exception.hpp"
 #include "coincenterinfo.hpp"
 #include "commonapi.hpp"
+#include "currencycode.hpp"
 #include "exchangeinfo.hpp"
 #include "exchangepublicapi_mock.hpp"
+#include "exchangepublicapitypes.hpp"
 #include "fiatconverter.hpp"
+#include "loadconfiguration.hpp"
+#include "market.hpp"
+#include "marketorderbook.hpp"
+#include "monetaryamount.hpp"
+#include "runmodes.hpp"
+#include "timedef.hpp"
+#include "volumeandpricenbdecimals.hpp"
 
 namespace cct::api {
 class ExchangePublicTest : public ::testing::Test {

src/api/exchanges/src/bithumbprivateapi.cpp

@@ -1,25 +1,55 @@
 #include "bithumbprivateapi.hpp"
 
 #include <algorithm>
-#include <cassert>
-#include <execution>
+#include <array>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <iterator>
+#include <string_view>
 #include <thread>
+#include <utility>
 
+#include "accountowner.hpp"
 #include "apikey.hpp"
+#include "apiquerytypeenum.hpp"
+#include "balanceoptions.hpp"
+#include "balanceportfolio.hpp"
 #include "bithumbpublicapi.hpp"
+#include "cachedresult.hpp"
 #include "cct_exception.hpp"
+#include "cct_fixedcapacityvector.hpp"
 #include "cct_json.hpp"
 #include "cct_log.hpp"
 #include "cct_smallvector.hpp"
+#include "cct_string.hpp"
 #include "codec.hpp"
 #include "coincenterinfo.hpp"
+#include "curlhandle.hpp"
 #include "curloptions.hpp"
+#include "currencycode.hpp"
+#include "exchangeinfo.hpp"
+#include "exchangeprivateapitypes.hpp"
+#include "exchangepublicapitypes.hpp"
 #include "file.hpp"
+#include "httprequesttype.hpp"
+#include "monetaryamount.hpp"
+#include "order.hpp"
+#include "ordersconstraints.hpp"
+#include "runmodes.hpp"
 #include "ssl_sha.hpp"
 #include "stringhelpers.hpp"
 #include "timedef.hpp"
 #include "timestring.hpp"
+#include "tradedamounts.hpp"
+#include "tradeinfo.hpp"
 #include "tradeoptions.hpp"
+#include "tradeside.hpp"
+#include "wallet.hpp"
+#include "withdraw.hpp"
+#include "withdrawordeposit.hpp"
+#include "withdrawsconstraints.hpp"
+#include "withdrawsordepositsconstraints.hpp"
 
 namespace cct::api {
 namespace {

src/api/exchanges/src/bithumbpublicapi.cpp

@@ -1,21 +1,38 @@
 #include "bithumbpublicapi.hpp"
 
 #include <algorithm>
-#include <cassert>
 #include <ctime>
+#include <iterator>
+#include <memory>
+#include <optional>
 #include <sstream>
 #include <string>
+#include <string_view>
+#include <utility>
 
+#include "apiquerytypeenum.hpp"
+#include "cachedresult.hpp"
 #include "cct_exception.hpp"
 #include "cct_json.hpp"
 #include "cct_log.hpp"
+#include "cct_string.hpp"
+#include "cct_vector.hpp"
 #include "coincenterinfo.hpp"
 #include "commonapi.hpp"
+#include "curlhandle.hpp"
 #include "curloptions.hpp"
+#include "currencycode.hpp"
+#include "currencyexchange.hpp"
+#include "exchangepublicapitypes.hpp"
 #include "fiatconverter.hpp"
+#include "httprequesttype.hpp"
+#include "market.hpp"
+#include "marketorderbook.hpp"
 #include "monetaryamount.hpp"
+#include "permanentcurloptions.hpp"
 #include "stringhelpers.hpp"
 #include "timestring.hpp"
+#include "tradeside.hpp"
 
 namespace cct::api {
 namespace {

src/api/exchanges/src/krakenprivateapi.cpp

@@ -1,21 +1,58 @@
 #include "krakenprivateapi.hpp"
 
-#include <cassert>
+#include <algorithm>
+#include <chrono>
+#include <cstdint>
+#include <memory>
+#include <string_view>
 #include <thread>
+#include <utility>
 
 #include "apikey.hpp"
+#include "apiquerytypeenum.hpp"
+#include "balanceoptions.hpp"
+#include "balanceportfolio.hpp"
+#include "cachedresult.hpp"
 #include "cct_exception.hpp"
 #include "cct_json.hpp"
 #include "cct_log.hpp"
+#include "cct_string.hpp"
+#include "cct_vector.hpp"
 #include "codec.hpp"
 #include "coincenterinfo.hpp"
+#include "commonapi.hpp"
+#include "curlhandle.hpp"
 #include "curloptions.hpp"
+#include "currencycode.hpp"
+#include "currencyexchange.hpp"
+#include "deposit.hpp"
+#include "depositsconstraints.hpp"
+#include "exchangeinfo.hpp"
+#include "exchangename.hpp"
+#include "exchangeprivateapi.hpp"
+#include "exchangeprivateapitypes.hpp"
+#include "exchangepublicapitypes.hpp"
+#include "httprequesttype.hpp"
 #include "krakenpublicapi.hpp"
+#include "market.hpp"
+#include "monetaryamount.hpp"
+#include "order.hpp"
+#include "orderid.hpp"
+#include "ordersconstraints.hpp"
+#include "permanentcurloptions.hpp"
 #include "ssl_sha.hpp"
 #include "stringhelpers.hpp"
 #include "timedef.hpp"
 #include "timestring.hpp"
 #include "toupperlower.hpp"
+#include "tradedamounts.hpp"
+#include "tradeinfo.hpp"
+#include "tradeside.hpp"
+#include "wallet.hpp"
+#include "withdraw.hpp"
+#include "withdrawinfo.hpp"
+#include "withdrawordeposit.hpp"
+#include "withdrawsconstraints.hpp"
 
 namespace cct::api {
 namespace {

src/api/exchanges/src/kucoinprivateapi.cpp

@@ -1,16 +1,55 @@
 #include "kucoinprivateapi.hpp"
 
-#include <thread>
+#include <algorithm>
+#include <cassert>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <string_view>
+#include <utility>
 
 #include "apikey.hpp"
+#include "apiquerytypeenum.hpp"
+#include "balanceoptions.hpp"
+#include "balanceportfolio.hpp"
+#include "cachedresult.hpp"
+#include "cct_exception.hpp"
+#include "cct_json.hpp"
+#include "cct_log.hpp"
+#include "cct_string.hpp"
 #include "codec.hpp"
 #include "coincenterinfo.hpp"
+#include "commonapi.hpp"
+#include "curlhandle.hpp"
 #include "curloptions.hpp"
+#include "currencycode.hpp"
+#include "deposit.hpp"
+#include "depositsconstraints.hpp"
+#include "exchangeinfo.hpp"
+#include "exchangename.hpp"
+#include "exchangeprivateapi.hpp"
+#include "exchangeprivateapitypes.hpp"
+#include "exchangepublicapitypes.hpp"
+#include "httprequesttype.hpp"
 #include "kucoinpublicapi.hpp"
+#include "market.hpp"
+#include "monetaryamount.hpp"
+#include "order.hpp"
+#include "orderid.hpp"
+#include "ordersconstraints.hpp"
+#include "permanentcurloptions.hpp"
 #include "ssl_sha.hpp"
 #include "stringhelpers.hpp"
+#include "timedef.hpp"
 #include "timestring.hpp"
-#include "toupperlower.hpp"
+#include "tradedamounts.hpp"
+#include "tradeinfo.hpp"
+#include "tradeside.hpp"
+#include "wallet.hpp"
+#include "withdraw.hpp"
+#include "withdrawinfo.hpp"
+#include "withdrawordeposit.hpp"
+#include "withdrawsconstraints.hpp"
 
 namespace cct::api {