Kraken - take nb last trade parameter option into account instead of …

…returning always 1000 last trades by default
sjanel · Aug 24, 2023 · 17f9b01 · 17f9b01
1 parent 45f6e7b
commit 17f9b01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/api/exchanges/include/krakenpublicapi.hpp b/src/api/exchanges/include/krakenpublicapi.hpp
@@ -51,7 +51,7 @@ class KrakenPublic : public ExchangePublic {
 
   MonetaryAmount queryLast24hVolume(Market mk) override { return _tickerCache.get(mk).first; }
 
-  LastTradesVector queryLastTrades(Market mk, int nbTrades = kNbLastTradesDefault) override;
+  LastTradesVector queryLastTrades(Market mk, int nbLastTrades = kNbLastTradesDefault) override;
 
   MonetaryAmount queryLastPrice(Market mk) override { return _tickerCache.get(mk).second; }
 

diff --git a/src/api/exchanges/src/krakenpublicapi.cpp b/src/api/exchanges/src/krakenpublicapi.cpp
@@ -505,10 +505,11 @@ KrakenPublic::TickerFunc::Last24hTradedVolumeAndLatestPricePair KrakenPublic::Ti
   throw exception("Invalid data retrieved from ticker information");
 }
 
-LastTradesVector KrakenPublic::queryLastTrades(Market mk, [[maybe_unused]] int nbTrades) {
+LastTradesVector KrakenPublic::queryLastTrades(Market mk, int nbLastTrades) {
   Market krakenMarket(_tradableCurrenciesCache.get().getOrThrow(mk.base()).altCode(),
                       _tradableCurrenciesCache.get().getOrThrow(mk.quote()).altCode());
-  json result = PublicQuery(_curlHandle, "/public/Trades", {{"pair", krakenMarket.assetsPairStrUpper()}});
+  json result = PublicQuery(_curlHandle, "/public/Trades",
+                            {{"pair", krakenMarket.assetsPairStrUpper()}, {"count", nbLastTrades}});
   LastTradesVector ret;
   for (const json& det : result.front()) {
     MonetaryAmount price(det[0].get<std::string_view>(), mk.quote());