SFTP: Allow to configure users via a secret #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR wants to bring
As title, I wonder if could be useful to configure the chart via a K8s secret that uses the same exact configuration as the one provided by
.Values.sftp.users
. If present, the secret would take the precedence.For example, instead of doing this:
We could alternatively get users' configuration from a
my-users-config
pre-existing secret in the following way:The
my-users-config
secret would be like this (please notice that I'm reading from ausers.conf
key):Please note
The code can be refactored as you may feel best to do. Additionally I have not updated the tests, but it won't be a problem to manage them if necessary :)