Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement join game function #84

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Benjtalkshow
Copy link

@Benjtalkshow Benjtalkshow commented Oct 1, 2024

closes #80

1 - join game function

Implemented a join game function which checks if the game with the given game_id is in a waiting state. Then adds the player's username to the appropriate color slot in the game state and If all required players have joined, it changes the game status from "Waiting" to "Ongoing".

2 - join game function test

Implemented test cases for the join game function which includes:

  1. Verifying that players can successfully join a game using different colors.
  2. Checks that the player's username is correctly added to the game state.
  3. Ensures the game status remains "Waiting" while players are joining.
  4. Confirms the game status changes to "Ongoing" when all required players have joined.

@Benjtalkshow Benjtalkshow marked this pull request as draft October 1, 2024 21:30
@princeibs
Copy link
Collaborator

@Benjtalkshow are you having any challenge completing this?
You can also ping the StarkLudo Contributors channel on Telegram if you need more clarity on this issue.

@Benjtalkshow
Copy link
Author

@Benjtalkshow are you having any challenge completing this? You can also ping the StarkLudo Contributors channel on Telegram if you need more clarity on this issue.

Yea just chatted you few min ago with handle Kitch. I am working on it.

@Benjtalkshow Benjtalkshow marked this pull request as ready for review October 3, 2024 21:42
Copy link
Collaborator

@princeibs princeibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • Please fix failing contract CI and client CI

@Benjtalkshow
Copy link
Author

@princeibs
Will make my final PR soon sir

@princeibs
Copy link
Collaborator

Please fix failing CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the "Join game" function
2 participants