Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sonar issues #671

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix: fix sonar issues #671

merged 4 commits into from
Oct 16, 2023

Conversation

Naman0133
Copy link
Contributor

Issue: #440

@welcome
Copy link

welcome bot commented Oct 14, 2023

Thanks so much for opening this pull request and for helping to improve SirixDB 🚀

@Naman0133 Naman0133 mentioned this pull request Oct 14, 2023
Closed
@JohannesLichtenberger
Copy link
Member

Can you format your changes with the SirixDB formatter?

@Naman0133
Copy link
Contributor Author

Naman0133 commented Oct 14, 2023 via email

@Naman0133
Copy link
Contributor Author

Can you format your changes with the SirixDB formatter?

I am seeing all checks are passing, can you tell me is formatter needed ? if yes then how to do?

@JohannesLichtenberger
Copy link
Member

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

@Naman0133
Copy link
Contributor Author

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

ohh okay will try and update the code

@Naman0133
Copy link
Contributor Author

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

Done, can you please review it now?
Thanks :)

@JohannesLichtenberger JohannesLichtenberger merged commit bac04bb into sirixdb:master Oct 16, 2023
3 checks passed
@welcome
Copy link

welcome bot commented Oct 16, 2023

Congrats on merging your first pull request. 🐬 You've just improved SirixDB for everyone. ❤️

@Naman0133
Copy link
Contributor Author

@JohannesLichtenberger Please add the hacktoberfest-accepted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naman0133 @JohannesLichtenberger @kanhaG2608