Simple refactor, typo fixes, added logger #639
Conversation
|
Thanks so much for opening this pull request and for helping to improve SirixDB 🚀 |
| @@ -151,7 +164,7 @@ public void remove() { | |||
| private static int defaultCapacity = 16; | |||
|
|
|||
| /** | |||
| * Holds the base hash entries. if the capacity is 2^N, than the base hash | |||
| * Holds the base hash entries. if the capacity is 2^N, thn the base hash | |||
There was a problem hiding this comment.
sill minor typo: I guess it's "then" ;-)
There was a problem hiding this comment.
Two times the charm :')
| @@ -619,7 +634,7 @@ public boolean equals(Object o) { | |||
|
|
|||
| T v1 = this.get(key); | |||
| T v2 = that.get(key); | |||
| if ((v1 == null && v2 != null) || (v1 != null && v2 == null) || (!v1.equals(v2))) { | |||
| if ((v1 == null && v2 != null) || (v1 != null && v2 == null) || (v1!= null && !v1.equals(v2))) { | |||
There was a problem hiding this comment.
we also may be able to use if (!Object.equals(v1, v2)) { return false };, but I'd have to check the implementation ;-)
There was a problem hiding this comment.
Or simply return Objects.equals(v1, v2);
There was a problem hiding this comment.
I'll keep that in mind
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -329,8 +329,7 @@ public boolean containsKey(int key) { | |||
| * false otherwise. | |||
| */ | |||
| public boolean containsValue(Object o) { | |||
| for (Iterator<T> iterator = iterator(); iterator.hasNext(); ) { | |||
| T object = iterator.next(); | |||
| for (T object : this) { | |||
There was a problem hiding this comment.
can explain why you used enhanced for-loop in this situation?
There was a problem hiding this comment.
No other reason than just making it more compact
There was a problem hiding this comment.
Though I can see it being an issue for some people if I'm being honest
There was a problem hiding this comment.
I think it's great :-)
| @@ -301,7 +314,7 @@ public void clear() { | |||
| // And setting all the <code>next[i]</code> to point at | |||
| // <code>i+1</code>. | |||
| for (int i = 1; i < this.capacity; ) { | |||
| next[i] = ++i; | |||
| next[i] = i + 1; | |||
There was a problem hiding this comment.
This is wrong, as it doesn't increment i anymore.
There was a problem hiding this comment.
What am I not seeing?
There was a problem hiding this comment.
oh the increment isn't even present in the method
There was a problem hiding this comment.
Gonna keep an eye out for silly mistakes
|
Congrats on merging your first pull request. 🐬 You've just improved SirixDB for everyone. ❤️ |
|
@shdowtail thanks for your contributions so far. Hope you'll be able to deep dive into the code base and keep on contributing :-) The |
I certainly will. Currently taking a course to refresh my mind of few things though |
No description provided.