Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing plugin for publishing #3

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Add missing plugin for publishing #3

merged 8 commits into from
Aug 7, 2024

Conversation

majk-p
Copy link
Member

@majk-p majk-p commented Jul 23, 2024

No description provided.

build.sbt Outdated
tlJdkRelease := Some(17),
organizationName := "SiriusXM",
startYear := Some(2024),
githubWorkflowPublishTargetBranches += RefPredicate.Equals(Ref.Branch("fix-publishing")),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this before merge, once we confirm that publishing works

Comment on lines -12 to -13
addSbtPlugin("org.typelevel" % "sbt-typelevel-github" % "0.7.1")
addSbtPlugin("org.typelevel" % "sbt-typelevel-github-actions" % "0.7.1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are removed in favor of sbt-typelevel-ci-release that includes them both

@majk-p majk-p requested a review from zainab-ali July 23, 2024 09:36
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@majk-p
Copy link
Member Author

majk-p commented Jul 24, 2024

Blocked by typelevel/sbt-typelevel#722

@majk-p majk-p merged commit 657db6e into main Aug 7, 2024
12 checks passed
@zainab-ali zainab-ali deleted the fix-publishing branch August 7, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants