feat: add error and success messages on edit page #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace the error handling with useStates for error and success and conditional Alert component.
- less code is needed in the components to use notifications for loading/success/error. - notifications will be consistent across the app and style/settings can be easily changed in one place. - a tsx file was needed to have the Icon component in the notifications. -> src/lib/notifications.tsx
its now handled inline in the EditRecipeForm component
there now rendered in the EditRecipeForm component instead
and change title placement + content ({recipe.title} instead of "Edit Recipe")
- zIndex:1000 made it appear on top of dropdowns/drawers -> zIndex:100 - small edit of margins
sirisayshello
approved these changes
Nov 18, 2024
sirisayshello
deleted the
182-feat-error-and-success-messages-on-edit-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.