Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI glitch on form submit #151

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

JoarHansson
Copy link
Collaborator

This PR fixes the UI form submit glitch, and it now feels smoother.

  • The fix was essentially to change where loading is set to false

Also:

  • Add a 500ms delay on form submit, so that the loading spinner doesn't just flash on quick req/res
  • Log the user in automatically after they have signed up and redirect to /welcome

- The fix was essentially to change where loading is set to false

Also:
- Add a 500ms delay on form submit, so that the loading spinner doesn't just flash on quick req/res
- Log the user in automatically after they have signed up and redirect to /welcome
@JoarHansson JoarHansson linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link
Owner

@sirisayshello sirisayshello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirisayshello sirisayshello merged commit f0db3cb into main Nov 5, 2024
1 of 2 checks passed
@sirisayshello sirisayshello deleted the 119-bug-ui-glitch-on-form-submit branch November 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: UI glitch on form submit
2 participants