Testing tooltip side closest to the target is in the right position

sir-dunxalot · Dec 22, 2016 · ac970b8 · ac970b8
1 parent 83dcb70
commit ac970b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test-support/helpers/ember-tooltips.js b/test-support/helpers/ember-tooltips.js
@@ -126,16 +126,16 @@ export function assertTooltipSide(assert, options = {}) {
   const tooltipPosition = $tooltip[0].getBoundingClientRect();
 
   if (expectedSide === 'top') {
-    assert.ok(targetPosition.top > tooltipPosition.top,
+    assert.ok(targetPosition.top > tooltipPosition.bottom,
       'Tooltip should be above the target');
   } else if (expectedSide === 'right') {
-    assert.ok(targetPosition.left < tooltipPosition.left,
+    assert.ok(targetPosition.right < tooltipPosition.left,
       'Tooltip should be right of the target');
   } else if (expectedSide === 'bottom') {
-    assert.ok(targetPosition.top < tooltipPosition.top,
+    assert.ok(targetPosition.bottom < tooltipPosition.top,
       'Tooltip should be below the target');
   } else if (expectedSide === 'left') {
-    assert.ok(targetPosition.left > tooltipPosition.left,
+    assert.ok(targetPosition.left > tooltipPosition.right,
       'Tooltip should be left of the target');
   }
 }
diff --git a/tests/integration/components/side-test.js b/tests/integration/components/side-test.js
@@ -73,6 +73,6 @@ test('tooltip-on-element shows with showOn left', function(assert) {
 //     {{/tooltip-on-element}}
 //   `);
 
-//    assertPosition(assert, this, 'right');
+//    assertTooltipSide(assert, { side: 'right' });
 
 // });