Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermal rework #32

Merged
merged 92 commits into from
Mar 4, 2024
Merged

Thermal rework #32

merged 92 commits into from
Mar 4, 2024

Commits on Feb 8, 2024

  1. Improve blackoil initialization

    @moyner
    moyner committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b798e1b View commit details
    Browse the repository at this point in the history

  2. Add verbose option to setup_case_from_parsed_data

    @moyner
    moyner committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    49485f2 View commit details
    Browse the repository at this point in the history

  3. Speed up initial state by explicit loop

    @moyner
    moyner committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    974c6ad View commit details
    Browse the repository at this point in the history

  4. Speed up initialization with many regions

    @moyner
    moyner committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    da500ba View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Remove debug output.

    @moyner
    moyner committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7d50304 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Clamp vapor fraction for k value flash

    @moyner
    moyner committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    93f8636 View commit details
    Browse the repository at this point in the history

  2. Improve assert message

    @moyner
    moyner committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5c5e1b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Add two variable defs for CO2 models

    @moyner
    moyner committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a2996d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fixes to CO2-brine PVT

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    56aa0e7 View commit details
    Browse the repository at this point in the history

  2. Add P-T tabulated viscosities

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4e0e62f View commit details
    Browse the repository at this point in the history

  3. Update flash.jl

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a04b337 View commit details
    Browse the repository at this point in the history

  4. Fix typo in saturations computed from density

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    232a6d2 View commit details
    Browse the repository at this point in the history

  5. Add KValueWrapper type

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    77fb9c8 View commit details
    Browse the repository at this point in the history

  6. Swap default component order for brine mixture

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    5d8a8bc View commit details
    Browse the repository at this point in the history

  7. Remove runtime dispatch from loop

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    bce6321 View commit details
    Browse the repository at this point in the history

  8. Clean up brine density

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    daf5408 View commit details
    Browse the repository at this point in the history

  9. Improve RESV weight calculation

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c3acd43 View commit details
    Browse the repository at this point in the history

  10. Fix typo in assert

    @moyner
    moyner committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2c7972d View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Cleanup in compositional

    @moyner
    moyner committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    27505bd View commit details
    Browse the repository at this point in the history

  2. Some small performance increases for k values

    @moyner
    moyner committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6461f5e View commit details
    Browse the repository at this point in the history

  3. Add a utility, clean up to kr

    @moyner
    moyner committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6d3c59b View commit details
    Browse the repository at this point in the history

  4. Update mrst_input.jl

    @moyner
    moyner committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3a98b84 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Add missing function for composite system

    @moyner
    moyner committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    951c8b0 View commit details
    Browse the repository at this point in the history

  2. A bunch of smaller thermal fixes

    @moyner
    moyner committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    01f4b2a View commit details
    Browse the repository at this point in the history

  3. Fix error in mole fraction increment norm

    @moyner
    moyner committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b4e9f17 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Improvement to endscale setup

    @moyner
    moyner committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8217cea View commit details
    Browse the repository at this point in the history

  2. Avoid crash for "nothing" control when split_wells = true

    @moyner
    moyner committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e78e653 View commit details
    Browse the repository at this point in the history

  3. Graceful handling of missing increments 

    This will only happen when a solver is really broken but still worth fixing
    @moyner
    moyner committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    081253c View commit details
    Browse the repository at this point in the history

  4. Avoid extra parameters for wells in thermal

    @moyner
    moyner committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5359ee5 View commit details
    Browse the repository at this point in the history

  5. Update multicomponent.jl

    @moyner
    moyner committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ebeb923 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Fixes to dt/well mix parsing

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    48b5626 View commit details
    Browse the repository at this point in the history

  2. Turn parser error into warning

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c9bfc94 View commit details
    Browse the repository at this point in the history

  3. Handle welopen

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a4f07d3 View commit details
    Browse the repository at this point in the history

  4. Handle well temperature

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b071cb9 View commit details
    Browse the repository at this point in the history

  5. Handle single phase "rel perm"

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    bc42901 View commit details
    Browse the repository at this point in the history

  6. Handle single phase in equilibriation

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    557b04c View commit details
    Browse the repository at this point in the history

  7. Some thermal scaffolding

    @moyner
    moyner committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1cc7110 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. A few thermal fixes

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a3c71d5 View commit details
    Browse the repository at this point in the history

  2. Update controls.jl

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a621e84 View commit details
    Browse the repository at this point in the history

  3. Thermal setup

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5a6da39 View commit details
    Browse the repository at this point in the history

  4. Don't use saturations as primary for single phase

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d6abf68 View commit details
    Browse the repository at this point in the history

  5. Update mrst_input.jl

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c330367 View commit details
    Browse the repository at this point in the history

  6. More composite fixes

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2aa18a6 View commit details
    Browse the repository at this point in the history

  7. Thermal fixes

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0f68a81 View commit details
    Browse the repository at this point in the history

  8. Handle initialization of thermal conductivities

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9d53d75 View commit details
    Browse the repository at this point in the history

  9. Transfer over some more thermal properties

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    677ee35 View commit details
    Browse the repository at this point in the history

  10. Temperature fix

    @moyner
    moyner committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    87e8b19 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Add subcrossterm to thermal

    @moyner
    moyner committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    435af17 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Allow passing of custom config to simulate_reservoir

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a1a4630 View commit details
    Browse the repository at this point in the history

  2. add PT table variable

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d7c213f View commit details
    Browse the repository at this point in the history

  3. Add heat capacities to reservoir_domain

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ff9490c View commit details
    Browse the repository at this point in the history

  4. Set default maximum temperature to 1 million degrees K

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b2b72db View commit details
    Browse the repository at this point in the history

  5. Use new thermal properties for default values

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4972508 View commit details
    Browse the repository at this point in the history

  6. Convergence criterion for energy

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ca0f609 View commit details
    Browse the repository at this point in the history

  7. Add missing kwarg

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ac1c20a View commit details
    Browse the repository at this point in the history

  8. Fix phase_face_average signature

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c418b81 View commit details
    Browse the repository at this point in the history

  9. Use face average for saturations in conductive flux

    @moyner
    moyner committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    77c9140 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Use analytical K-value flash when ncomp = 2 or 3

    @moyner
    moyner committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    525b7b2 View commit details
    Browse the repository at this point in the history

  2. Fixes to welopen

    @moyner
    moyner committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    02606fb View commit details
    Browse the repository at this point in the history

  3. Fix to PBVD init

    @moyner
    moyner committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ef8c175 View commit details
    Browse the repository at this point in the history

  4. Update init.jl

    @moyner
    moyner committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    be3808e View commit details
    Browse the repository at this point in the history

  5. Update init.jl

    @moyner
    moyner committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    095c1d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Put heat capacity per component instead of phase 

    Needed to generalize to miscible cases
    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    33fcd5c View commit details
    Browse the repository at this point in the history

  2. Some thermal related improvements

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    936ff4a View commit details
    Browse the repository at this point in the history

  3. Make ThermalSystem hold the flow system

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    114bb0d View commit details
    Browse the repository at this point in the history

  4. Add some dispatches for different thermal models

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    54ba562 View commit details
    Browse the repository at this point in the history

  5. Add compositional specialization of internal energy

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    0d272fd View commit details
    Browse the repository at this point in the history

  6. Update equations.jl

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e2adf47 View commit details
    Browse the repository at this point in the history

  7. Fix to thermal flux for compositional

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e8d5242 View commit details
    Browse the repository at this point in the history

  8. Move function to fix load order

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e32ed9a View commit details
    Browse the repository at this point in the history

  9. Make InjectorControl fully parametric

    @moyner
    moyner committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    f53f80b View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Add more fields to deck types

    @moyner
    moyner committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1d57f6d View commit details
    Browse the repository at this point in the history

  2. Add WATDENT to setup (not eval)

    @moyner
    moyner committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    12777f8 View commit details
    Browse the repository at this point in the history

  3. Put in place some more thermal stuff

    @moyner
    moyner committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6a566f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Switch dp abs to use MPa as scaling

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    cd5f7d6 View commit details
    Browse the repository at this point in the history

  2. Update utils.jl

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    359e813 View commit details
    Browse the repository at this point in the history

  3. Update utils.jl

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6475e97 View commit details
    Browse the repository at this point in the history

  4. Quick implementation of thermal viscosities from input file

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c6dd975 View commit details
    Browse the repository at this point in the history

  5. Support for WATDENT

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c70e279 View commit details
    Browse the repository at this point in the history

  6. Add enthalpy mixing draft

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    bba0e59 View commit details
    Browse the repository at this point in the history

  7. Handle WTEMP order like WEFAC etc

    @moyner
    moyner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    dddb157 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Improve thermal viscosity logic

    @moyner
    moyner committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c4fb95f View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Make use of InjectorControl enthalpy

    @moyner
    moyner committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4aebac9 View commit details
    Browse the repository at this point in the history

  2. Go via internal energy for well enthalpy when not specified

    @moyner
    moyner committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2873192 View commit details
    Browse the repository at this point in the history

  3. Add diffusion to compositional flux

    @moyner
    moyner committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    448e8cd View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Make thermal variable change configurable

    @moyner
    moyner committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0c89a0f View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Use saturation min for diffusion 

    Avoid cross-phase diffusion when phase is absent
    @moyner
    moyner committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    ccba1aa View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Patch to well enthalpy

    @moyner
    moyner committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b73ca17 View commit details
    Browse the repository at this point in the history

  2. Fix to function dispatch for K-values

    @moyner
    moyner committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    548fd84 View commit details
    Browse the repository at this point in the history

  3. Clean up old code

    @moyner
    moyner committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6bab313 View commit details
    Browse the repository at this point in the history

  4. Fix to test

    @moyner
    moyner committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9184a0a View commit details
    Browse the repository at this point in the history

  5. Simplify bouyancy term when properties exist

    @moyner
    moyner committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2c40d6e View commit details
    Browse the repository at this point in the history