Skip to content

Commit

Permalink
Changed definitions of overridden functions to match the original (#49)
Browse files Browse the repository at this point in the history
Summary:
In #46 I override 4 functions
of the MySqlGrammar and added a return type to the definition.
Occurred that this is a breaking change as all users that extended from our class and
override the same functions - also should add the return type.
  • Loading branch information
AdalbertMemSQL authored Dec 19, 2022
1 parent 0c72883 commit f908d91
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Query/Grammar.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ protected function wrapJsonFieldAndPath($column)
* @param string $sql
* @return string
*/
protected function wrapUnion($sql): string
protected function wrapUnion($sql)
{
return 'SELECT * FROM ('.$sql.')';
}
Expand All @@ -156,7 +156,7 @@ protected function wrapUnion($sql): string
* @param Builder $query
* @return string
*/
protected function compileUnions(Builder $query): string
protected function compileUnions(Builder $query)
{
$sql = '';

Expand All @@ -173,7 +173,7 @@ protected function compileUnions(Builder $query): string
* @param Builder $query
* @return string
*/
public function compileSelect(Builder $query): string
public function compileSelect(Builder $query)
{
$sql = parent::compileSelect($query);

Expand Down Expand Up @@ -203,7 +203,7 @@ public function compileSelect(Builder $query): string
* @param $offset
* @return string
*/
protected function compileOffset(Builder $query, $offset): string
protected function compileOffset(Builder $query, $offset)
{
return $this->compileOffsetWithLimit($offset, $query->limit);
}
Expand Down

0 comments on commit f908d91

Please sign in to comment.