Skip to content

Commit

Permalink
more nits
Browse files Browse the repository at this point in the history
  • Loading branch information
drodrigues4 committed Jul 24, 2024
1 parent d09afcc commit f11e571
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ import type {
} from '~/singlestore-core/session.ts';
import type { Query, SQL, SQLWrapper } from '~/sql/sql.ts';
import type { SingleStoreTable } from '../table.ts';
import type { OptimizeTableArgument, SelectedColumns } from './optimizeTable.types.ts';
import type { OptimizeTableArgument } from './optimizeTable.types.ts';
import type { SingleStoreColumn } from '../columns/common.ts';
import type { ColumnBaseConfig, ColumnDataType } from '~/index.ts';

export type SingleStoreOptimizeTableWithout<
T extends AnySingleStoreOptimizeTableBase,
Expand Down Expand Up @@ -41,7 +43,7 @@ export type SingleStoreOptimizeTable<
export interface SingleStoreOptimizeTableConfig {
table: SingleStoreTable;
arg?: OptimizeTableArgument | undefined;
selection?: SelectedColumns | undefined;
selection?: SingleStoreColumn<ColumnBaseConfig<ColumnDataType, string>, object>[] | undefined;
}

export type SingleStoreOptimizeTablePrepare<T extends AnySingleStoreOptimizeTableBase> = PreparedQueryKind<
Expand Down Expand Up @@ -105,7 +107,7 @@ export class SingleStoreOptimizeTableBase<
}

// TODO(singlestore): docs
warmBlobCacheForColumn(...selection: SelectedColumns): SingleStoreOptimizeTableWithout<this, TDynamic, 'warmBlobCacheForColumn'> {
warmBlobCacheForColumn(...selection: SingleStoreColumn<ColumnBaseConfig<ColumnDataType, string>, object>[]): SingleStoreOptimizeTableWithout<this, TDynamic, 'warmBlobCacheForColumn'> {
if (this.config.arg) {
throw new Error('Cannot call warmBlobCacheForColumn with an argument');
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import type { SingleStoreColumn } from ".."
import type { ColumnBaseConfig, ColumnDataType } from "~/index"

export type OptimizeTableArgument =
| 'FULL'
| 'FLUSH'
| 'FIX_ALTER'
| 'INDEX'

export type SelectedColumns = [SingleStoreColumn<ColumnBaseConfig<ColumnDataType, string>, object>]

0 comments on commit f11e571

Please sign in to comment.