Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Add GeometryDataFrame creation #3674

Merged
merged 14 commits into from
Feb 11, 2025

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Feb 5, 2025

Issue and/or context: sc-50295

Changes:

Notes for Reviewer:
Adds basic implementation for GeometryDataFrame in the python API, adds static create method and property accessors.
Adapt already existing read methods from arrow tables to work with the newly introduced complex domain (a struct on values) used by soma_geometry column.

@XanthosXanthopoulos XanthosXanthopoulos force-pushed the xan/sc-59427/geometry-dataframe-python branch from a61a126 to 9080ee3 Compare February 5, 2025 15:13
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 83.59375% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (1754fcd) to head (9852763).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   86.29%   86.35%   +0.06%     
==========================================
  Files          55       55              
  Lines        6390     6495     +105     
==========================================
+ Hits         5514     5609      +95     
- Misses        876      886      +10     
Flag Coverage Δ
python 86.35% <83.59%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.35% <83.59%> (+0.06%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@XanthosXanthopoulos XanthosXanthopoulos changed the title [c++/python] Add GeometryDataFrame creation [WIP] [c++/python] Add GeometryDataFrame creation Feb 6, 2025
@XanthosXanthopoulos XanthosXanthopoulos marked this pull request as ready for review February 6, 2025 12:32
@XanthosXanthopoulos XanthosXanthopoulos merged commit 552dfc0 into main Feb 11, 2025
28 checks passed
@XanthosXanthopoulos XanthosXanthopoulos deleted the xan/sc-59427/geometry-dataframe-python branch February 11, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants