Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Remove arrow_*_from_tiledb_*() Helpers #3646

Conversation

mojaveazure
Copy link
Member

@mojaveazure mojaveazure commented Jan 30, 2025

Remove the following arrow <> tiledb-r helpers as they are unused and to start removing tiledb-r from the code/tests

  • arrow_field_from_tiledb_dim()
  • arrow_field_from_tiledb_attr()
  • arrow_schema_from_tiledb_schema()

SC-62761

continues work for #2406

Note: this PR is not going into main, but into a separate branch to accumulate all of these little PRs before filing the larger one to remove tiledb-r

Remove the following arrow <> tiledb-r helpers as they are unused and to
start removing tiledb-r from the code/tests

 - `arrow_field_from_tiledb_dim()`
 - `arrow_field_from_tiledb_attr()`
 - `arrow_schema_from_tiledb_schema()`

[SC-62761](https://app.shortcut.com/tiledb-inc/story/62761)
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫

@mojaveazure mojaveazure merged commit 59b3922 into paulhoffman/sc-62760/remove-tiledb-r-as-a-dependency-from-tiledbsoma Jan 30, 2025
4 checks passed
@mojaveazure mojaveazure deleted the paulhoffman/sc-62761/remove-arrow-from-tiledb-helpers branch January 30, 2025 23:54
mojaveazure added a commit that referenced this pull request Feb 3, 2025
* [r] Remove `arrow_*_from_tiledb_*()` Helpers
Remove the following arrow <> tiledb-r helpers as they are unused and to
start removing tiledb-r from the code/tests

 - `arrow_field_from_tiledb_dim()`
 - `arrow_field_from_tiledb_attr()`
 - `arrow_schema_from_tiledb_schema()`

[SC-62761](https://app.shortcut.com/tiledb-inc/story/62761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants